This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Build libgcj, libgcj-tools, and libffi as shared libraries on Windows


Dave Korn wrote:
Aaron W. LaFramboise wrote:
Dave Korn wrote:

Index: gcc/config/i386/t-cygming
+jc1$(exeext): LDFLAGS+=-Wl,-stack,0x8000000
I think it would be better to figure out why the top-level LDFLAGS does
not get propagated properly into java as it does for every other
language, rather than sticking in this hack.

Two questions:


-  Why "hack"?  It's a robust mechanism specified in the GNU Make manual as
far as I know.
-  What does this have to do with the top-level LDFLAGS?  I didn't change them
because I don't want cc1 and cc1plus to also have 128meg of stack, do I?

Look at config/mh-mingw, where this is set in LDFLAGS for the entire build. A while back, someone or other decided that this was the right thing to do. This value should be propagated into gcc/java, the same way that it is for everything else, but for some weird reason, it doesn't propagate through the build machinery. The value that is there is large enough for jc1.exe to compile libjava.


I think the right thing to do is fix that bug, rather than just hacking it to use the flag that it should already be using, if you see what I mean.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]