This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix PR39701 testsuite failures


On Fri, Apr 10, 2009 at 09:17:51AM +0200, Paolo Bonzini wrote:
> 
> One is a Fortran front-end bug due to the same disabled folding.  There
> is a mismatch in that "&stat" is compared with a zero constant whose
> type is "stat"'s type.
> 
>   Observation: This is easily fixed, but can be improved by just
>   deleting the conditionals emitted for the Fortran ALLOCATE intrinsics.
>   It never happens that those conditionals of the form "pstat == 0"
>   enter the "then" block, because pstat is always an ADDR_EXPR of a
>   stack-allocated variable.  It may be easier to just pass around the
>   DECL of the stat variable itself.  I'll leave this to the Fortran
>   maintainers.
> 
> 
> fortran:
> 2009-04-10  Paolo Bonzini  <bonzini@gnu.org>
> 
> 	* trans.c (gfc_allocate_with_status): Fix type mismatches
> 	on "pstat == 0".
> 

This is OK.  Note, at some point in the near future, I'll
be working on ALLOCATE, so I'll take your observation and
act upon your rocommendation.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]