This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR target/39678: complex type isn't passed correctly


On Fri, Apr 10, 2009 at 1:00 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Apr 9, 2009 at 2:44 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, Apr 9, 2009 at 2:19 PM, Richard Guenther
>> <richard.guenther@gmail.com> wrote:
>>> On Thu, Apr 9, 2009 at 11:17 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
>>>>
>>>>> Not 4.4.0? ?I don't think we should change the ABI in minor versions. ?Note
>>>>> that this is also a wrong-code bug as the caller ABI doesn't agree with
>>>>> the callee ABI for GCC at the moment.
>>>>
>>>> If this is the case, we may even not warn about it.
>>>
>>> Yes. ?It may only concern interoperation with different compilers.
>>> (I think the warning might be useful still, but note that it trigges with
>>> libstdc++ headers)
>>>
>>
>> Since gcc silently generates wrong code which never worked,
>> what should we do with gcc 4.3? If we fix gcc 4.3, do we need
>> the ABI warning?
>>
>
> I checked the fix into trunk and will backport to 4.4 branch in a day
> or 2. I don't think we need to generate a warning. The fix
> should be also backported to 4.3.

We do not need to rush here, I think waiting a bit longer for possible
fallout is good.

Richard.

>
> --
> H.J.
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]