This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: tests for --help
On Thu, 2009-04-09 at 09:44 +0100, Rafael Espindola wrote:
> > Usually a .exp file is infrastructure for tests from other files, so
> > help.exp deserves a comment at the start that it is a set of tests.
> Done.
>
> > Some of the comments are not full sentences, some don't start with a
> > capitalized word, and some don't end with a period. Some are missing
> > (meaning it would be helpful to have additional comments as well).
>
> I fixed the capitalized words and missing periods. Ralf, can you take
> a look at the missing comments?
>
> > In help.exp, it would be easier to read the calls to check_for_options
> > if the arguments were passed as strings instead of within braces; I'm
> > pretty sure that would work.
>
> It does except for strings with newlines or +. I changed all other strings.
>
> > It shouldn't be necessary to use "\{" for puts; in other files "{"
> > comes through just fine.
>
> Done.
>
> > In proc check_for_options it's confusing to have an argument called
> > xfail when the proc calls a procedure of that name; please rename the
> > argument to lessen the chances for confusion.
>
> Done.
>
> > Why is there an unconditional "pass $test" at the end of options.exp?
>
> No idea. Ralf?
Take a look at the "pass $test", but otherwise it looks good.
Janis