This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] License changes


On Thu, 9 Apr 2009, Jakub Jelinek wrote:

> On Wed, Apr 08, 2009 at 10:55:58PM +0000, Joseph S. Myers wrote:
> > I have reviewed the logs and the diffs to individual files, and the
> > patch is OK subject to the comments below (which suggest reposting
> > fixed versions of the libgomp and libobjc changes and committing the
> > rest, fixed as indicated).  I have not reviewed for the questions of:
> > 
> > * Should other files have the exception that presently do not?
> > 
> > * Are there files that after this patch still use GPLv2, LGPLv2 or
> >   LGPLv2.1, with or without exception, or that are missing copyright
> >   and license notices, that should change to GPLv3, with or without
> >   exception?
> > 
> > These questions are better reviewed once the patch has been checked
> > in.
> 
> Agreed.
> 
> > > 	* config/arm/arm_neon.h: Likewise.
> 
> ...
> The rest of the comments hopefully all incorporated, except for dropping
> makefile.dos, that can be done separately. Plus 153 newly added libstdc++-v3
> tests and config/vax/linux.h got added, 217 gcc/ada/ files removed from the
> patch as copyright holder isn't FSF or isn't solely FSF.

I have rereviewed the libobjc and libgomp changes and changes to files I 
specifically mentioned, and believe this patch addresses my comments, 
except that:

It still introduces typos "Foundaion" or "later ersion" into 
libobjc/init.c, libobjc/class.c, libobjc/exception.c, 
libobjc/NXConstStr.m, libobjc/Object.m, libobjc/archive.c.

The following Ada files have commas introduced into their copyright years 
where there was previously a single year listed (I think the Ada practice 
in this case is still to use a range not a comma): gcc/ada/g-rannum.ads 
gcc/ada/targext.c gcc/ada/a-einuoc.adb gcc/ada/a-einuoc.ads 
gcc/ada/vx_stack_info.c gcc/ada/s-dsaser.ads gcc/ada/s-proinf.adb 
gcc/ada/a-calcon.adb gcc/ada/a-calcon.ads gcc/ada/a-assert.adb 
gcc/ada/g-timsta.adb gcc/ada/g-timsta.ads gcc/ada/g-rannum.adb.

I have not rereviewed the libstdc++ changes or changes elsewhere in the 
patch.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]