This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add Intel Atom optimization


On Mon, Apr 6, 2009 at 6:57 PM, Ye, Joey <joey.ye@intel.com> wrote:
> From: Uros Bizjak [mailto:ubizjak@gmail.com]
>>> ? ? ? ?(distance_non_agu_define): New function.
>>> ? ? ? ?(reg_mentioned_by_mem_p): Likewise.
>>> ? ? ? ?(distance_agu_use): Likewise.
>>> ? ? ? ?(ix86_lea_for_add_ok): Likewise.
>>
>> please remove above functions from the patch and put them in a
>> separate follow-up patch. The main problem is with LEA discovery code
>> (see the comment above distance_non_agu_define). Since this function
>> is used after reload, we can use get_attr_type function on the insn
>> RTL. This func will determine, if insn is LEA or not. Also, perhaps
>> Steven B sees some opportunity to use DF infrastructure here instead
>> of scanning insn stream every time the function is called.
> Since get_attr_type will mess up current operands, we failed to use it in
> this patch. Namely, these functions will be called when splitting one insn.
> But get_attr_type will call recog and rewrite global variables like operands.
> Can extract_insn_cached help here?
>
> HJ has sent a patch without these functions.

FWIW, the initial Atom patch has been checked into trunk. I also
synced Atom branch with trunk at revision 145636. We just need
to submit a follow-up patch based on comments from Uros.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]