This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [trunk][patch] Remove the comdat_group langhook


On Wed, Apr 1, 2009 at 05:48, Rafael Espindola <espindola@google.com> wrote:
> This patch removes the comdat_group langhook. The patch is already on
> the LTO branch where it is needed. Once cc1plus is finished, we cannot
> call into the c++ hook and lto1 would put symbols in the wrong comdat
> group.
>
> This patch should go on top of my previous one to avoid issuing
> warnings in mangle_decl.
>
> OK if bootstraps and tests are OK?
>
> gcc/
> 2009-04-01 ÂRafael Avila de Espindola Â<espindola@google.com>
>
> Â Â Â Â* cgraphunit.c (cgraph_function_versioning,save_inline_function_body):
> Â Â Â ÂUse DECL_COMDAT_GROUP instead of DECL_ONE_ONLY.
> Â Â Â Â* config/i386/i386.c (ix86_file_end): Compute DECL_COMDAT_GROUP.
> Â Â Â Â* dwarf2asm.c(dw2_force_const_mem): Update call to make_decl_one_only.
> Â Â Â Â* langhooks-def.h (lhd_comdat_group): Change signature.
> Â Â Â Â(LANG_HOOKS_COMDAT_GROUP): Remove.
> Â Â Â Â(LANG_HOOKS_DECLS): Remove LANG_HOOKS_COMDAT_GROUP.
> Â Â Â Â* langhooks.c (lhd_comdat_group): Remove.
> Â Â Â Â* langhooks.h (lang_hooks_for_decls): Remove comdat_group.
> Â Â Â Â* tree.h (DECL_COMDAT_GROUP): New.
> Â Â Â Â(DECL_ONE_ONLY): Use DECL_COMDAT_GROUP.
> Â Â Â Â(tree_decl_with_vis): Add comdat_group. Remove one_only.
> Â Â Â Â(make_decl_one_only): Change signature.
> Â Â Â Â* varasm.c (get_emutls_init_templ_addr, emutls_decl): Update call to
> Â Â Â Âmake_decl_one_only.
> Â Â Â Â(make_decl_one_only): Change signature.
> Â Â Â Â(default_elf_asm_named_section): Use DECL_COMDAT_GROUP.
>
> gcc/cp
> 2009-01-09 ÂRafael Avila de Espindola Â<espindola@google.com>
>
> Â Â Â Â* cp-objcp-common.h (LANG_HOOKS_COMDAT_GROUP): Remove.
> Â Â Â Â* cp-tree.h (cxx_comdat_group): Change signature.
> Â Â Â Â* decl.c (duplicate_decls): Use DECL_COMDAT_GROUP.
> Â Â Â Â(cxx_comdat_group): Change signature.
> Â Â Â Â* decl2.c (comdat_linkage, maybe_make_one_only): Update call to
> Â Â Â Âmake_decl_one_only.
> Â Â Â Â(constrain_visibility, get_guard): Use DECL_COMDAT_GROUP.
> Â Â Â Â* method.c (use_thunk): Update call to make_decl_one_only.
> Â Â Â Â* optimize.c (maybe_clone_body): Use DECL_COMDAT_GROUP.

OK with me.  Again, I would like separate reviews from front end and
back end maintainers.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]