This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [cond-optab] Convert mips
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 06 Apr 2009 18:08:28 +0100
- Subject: Re: [cond-optab] Convert mips
- References: <49DA1D0F.7050104@gnu.org>
Paolo Bonzini <bonzini@gnu.org> writes:
> Here it is, one of the three I had missed last time.
>
> Built libgcc/newlib, will do assembly language testsuite comparisons next.
Looks good, thanks.
You haven't updated some of the comments above the functions whose
interfaces have changed. E.g. the comments above mips_emit_compare
and mips_emit_scc still refer to cmp_operands, although you've
probably caught the other cases. And the comment above mips_emit_scc
still claims that the function returns a boolean result.
> @@ -4337,17 +4336,17 @@ mips_expand_conditional_trap (enum rtx_c
> case GTU:
> case LEU:
> code = swap_condition (code);
> - op0 = cmp_operands[1];
> - op1 = cmp_operands[0];
> + op0 = XEXP (comparison, 0);
> + op1 = XEXP (comparison, 1);
> break;
>
> default:
> - op0 = cmp_operands[0];
> - op1 = cmp_operands[1];
> + op0 = XEXP (comparison, 1);
> + op1 = XEXP (comparison, 0);
> break;
This seems to reverse op0 and op1.
Richard