This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: tree-ssa-sink breaks stack layout

Mark Mitchell wrote:

> (1) What can we do to eliminate a serious defect in the short-term?
> This is a case of silently generating wrong code, with a simple,
> reasonable test case.

I'd also like to hear what people think of Sandra's original patch in
this regard.  The comment in tree-ssa-sink already talks about a set of
things that we can't safely do:

In particular:

"We can't sink things that may be global stores, at least not without
calculating a lot more information, because we may cause it to no longer
be seen by an external routine that needs it depending on where it gets
moved to."

Aren't moving references to block-scope variables quite similar in this
respect?

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]