This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [plugins] RFA: Merge plugins into mainline [4/5 - configury]


Thanks Ian for the very thorough review, I'll just add a couple notes.

>> - ? ?vec.h $(TARGET_H) $(CGRAPH_H)
>> + ? ?vec.h $(TARGET_H) $(CGRAPH_H) plugin.h
>
> It seems to me that plugin.h includes gcc-plugin.h, so you need to
> introduce a PLUGIN_H make variable and use it in the dependencies.

Indeed, I think dependencies should not be in the "configury" patch.
(A note for the future only).

>> + ?# Check for ELF target.

Separate checks for -ldl *and* -rdynamic would be preferrable.  In
case in the future some alternative to -rdynamic is introduced (e.g.
for Windows, which can use GetModuleHandle+GetProcAddress) it is
easier if there is less coupling between different tests.

>> + ? ?*-*-elf* | *-*-sysv4* | *-*-unixware* | *-*-eabi* | hppa*64*-*-hpux* \
>> + ? ?| *-*-linux* | frv-*-uclinux* | *-*-irix5* | *-*-irix6* \
>> + ? ?| *-*-netbsd* | *-*-openbsd* | *-*-freebsd* | *-*-solaris2*)
>> + ? ? ?case "${target}" in
>> + ? ? ? ?*-*-linux*aout* | *-*-linux*oldld*)
>> + ? ? ? ? ?;;
>> + ? ? ? ?*)
>> + ? ? ? ? ?is_elf=yes
>> + ? ? ? ? ?;;

*-*-linux*aout* | *-*-linux*oldld*) ;;
*-*-elf* | *-*-sysv4* | *-*-unixware* | *-*-eabi* | hppa*64*-*-hpux* \
   | *-*-linux* | frv-*-uclinux* | *-*-irix5* | *-*-irix6* \
   | *-*-netbsd* | *-*-openbsd* | *-*-freebsd* | *-*-solaris2*)
      is_elf=yes ;;
*) ;;

> Testing ${target} here is wrong. ?It should test ${host}.

Agreed.

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]