This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [plugins] RFA: Merge plugins into mainline [1/5 - C FE]
- From: Ian Lance Taylor <iant at google dot com>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Le-Chun Wu <lcwu at google dot com>, joseph at codesourcery dot com
- Date: Fri, 03 Apr 2009 18:22:36 -0700
- Subject: Re: [plugins] RFA: Merge plugins into mainline [1/5 - C FE]
- References: <20090402161503.GA20874@google.com>
Diego Novillo <dnovillo@google.com> writes:
> 2009-04-02 Le-Chun Wu <lcwu@google.com>
>
> * c-parser.c (c_parser_declspecs): Call invoke_plugin_callbacks.
>
> t = c_parser_struct_or_union_specifier (parser);
> + /* Invoke registered plugin callbacks if any. */
> + invoke_plugin_callbacks (PLUGIN_FINISH_STRUCT, t.spec);
> declspecs_add_type (specs, t);
I don't think that comment adds value.
I think it's nicer to use tabs, especially since the other lines do.
More seriously, while I know that the plugin API is going to change over
time, why do we have PLUGIN_FINISH_STRUCT and not, e.g.,
PLUGIN_FINISH_TYPE?
Ian