This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][SH] Fix SH4A atomicity.h


Andrew Stubbs <ams@codesourcery.com> wrote:
> The SH4A/SH4AL implementation of atomicity.h is broken. The problem is 
> that it won't link because the symbols are in the wrong namespace. 
> There's also some evidence of C programming in C++. I don't understand 
> how this could ever have worked for anybody.
> 
> This patch fixes the problem. It's a bit hard to see what's changed due 
> to the indent change. Here's an alternative diff ignoring whitespace:
> 
> --- atomicity.h (revision 145441)
> +++ atomicity.h (working copy)

Missing ChangeLog entry and the new copyright year :-)  I assume
that the patch is against libstdc++-v3/config/cpu/sh/atomicity.h
and you've tested it on an appropriate SH4A target.
If it's the case, OK with the updated copyright year and a ChangeLog
entry, though please give attention to the frozen trunk

  http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00175.html

which I've just noticed.

Regards,
	kaz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]