This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH][SH] Fix SH4A atomicity.h
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: ams at codesourcery dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 03 Apr 2009 07:08:32 +0900 (JST)
- Subject: Re: [PATCH][SH] Fix SH4A atomicity.h
- References: <49D4BD03.firstname.lastname@example.org>
Andrew Stubbs <email@example.com> wrote:
> The SH4A/SH4AL implementation of atomicity.h is broken. The problem is
> that it won't link because the symbols are in the wrong namespace.
> There's also some evidence of C programming in C++. I don't understand
> how this could ever have worked for anybody.
> This patch fixes the problem. It's a bit hard to see what's changed due
> to the indent change. Here's an alternative diff ignoring whitespace:
> --- atomicity.h (revision 145441)
> +++ atomicity.h (working copy)
Missing ChangeLog entry and the new copyright year :-) I assume
that the patch is against libstdc++-v3/config/cpu/sh/atomicity.h
and you've tested it on an appropriate SH4A target.
If it's the case, OK with the updated copyright year and a ChangeLog
entry, though please give attention to the frozen trunk
which I've just noticed.