This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] Fix asm parsing error recovery (PR c/37772)
On Wed, 2009-04-01 at 12:54 +0000, Joseph S. Myers wrote:
> On Wed, 1 Apr 2009, Jakub Jelinek wrote:
>
> > Hi!
> >
> > When asm ( isn't followed by a string literal (nor a wide string),
> > the C parser crashes when trying to build_asm_expr with NULL str. The C++
> > FE handles this gracefully.
> >
> > Fixed thusly, bootstrapped/regtested on x86_64-linux, ok for trunk/4.4?
> >
> > 2009-04-01 Jakub Jelinek <jakub@redhat.com>
> >
> > PR c/37772
> > * c-parser.c (c_parser_asm_statement): Skip until close paren and
> > return if c_parser_asm_string_literal returned NULL.
> >
> > * gcc.dg/pr37772.c: New test.
>
> OK (I can't approve the C++ testcase).
>
> > * g++.dg/ext/asm11.C: New test.
I think you should be able to approve a C++ testcase for a patch
to code shared by C and C++.
The C++ test is OK.
Janis