This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [SH] double precision floating point dwarf fix


Christian BRUEL <christian.bruel@st.com> wrote:
> This fixes the DWARF information for double precision floating point 
> values in register location for little endian SHs
[snip]
> The only SH core that I know about that have register numbering correct 
> is sh-300 when PR=SZ=1. I commented it out in the code for reference, in 
> case -mfmovd implies SZ=1. But not by default since this is not the ABI.

Could you give a comment for the new function at the just
before the function?  The inline comment for sh-300 could
be move into it too.  The patch itself looks ok.

>	(TARGET_DWARF_REGISTER_SPAN): Defined.
>	* config/sh/sh-protos.h (sh_dwarf_register_span): Declared.

s/d\./\./
I guess that the active voice is usual in gcc/ChangeLog for these.

Regards,
	kaz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]