This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: More MUST_NOT_THROW region cleanups
- From: Diego Novillo <dnovillo at google dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 30 Mar 2009 14:08:49 -0400
- Subject: Re: More MUST_NOT_THROW region cleanups
- References: <20090330165711.GP6448@kam.mff.cuni.cz>
On Mon, Mar 30, 2009 at 12:57, Jan Hubicka <hubicka@ucw.cz> wrote:
> The patch eliminates about half of the regions on tramp3d saving
Nice.
> + Â/* MUST_NOT_THROW regions without local handler are all the same; they
> + Â Â trigger terminate call in runtime.
> + Â Â MUST_NOT_THROW handled locally can differ in debug info associated
> + Â Â to std::terminate () call or if one is comming from Java and other
s/comming/coming/
> + Â Â from C++ whether they call terminate or abort.
> +
> + Â Â We merge all runtime handler MUST_NOT_THROW region into single
I can't parse this.
> + Â Â Merging of local receivers can not be done without redirecting CFG
> + Â Â and is job for crossjumping that can decide whether cleanup really
> + Â Â is the same. Â*/
Nor this.
> +
> + Âif (local_must_not_throw)
> + Â Âfirst_must_not_throw = local_must_not_throw;
> +
> + Âfor (i = 0; VEC_iterate (eh_region, must_not_throws, i, r); i++)
> + Â Â{
> + Â Â Âif (!r->label && !r->tree_label && r != first_must_not_throw)
> + Â Â Â {
> + Â Â Â Â if (dump_file)
> + Â Â Â Â Â fprintf (dump_file, "Replacing MUST_NOT_THROW region %i by %i\n",
s/by/with/
OK otherwise.
Diego.