This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C PATCH] Emit debug info for block local externs from C (PR debug/39563)


>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:

Jakub> @@ -824,6 +827,26 @@ pop_scope (void)
Jakub>  	      TREE_CHAIN (p) = BLOCK_VARS (block);
Jakub>  	      BLOCK_VARS (block) = p;
Jakub>  	    }
Jakub> +	  else if (VAR_OR_FUNCTION_DECL_P (p))
Jakub> +	    {
Jakub> +	      tree extp = copy_node (p);
Jakub> +
Jakub> +	      DECL_EXTERNAL (extp) = 1;
Jakub> +	      TREE_STATIC (extp) = 0;
[...]

I think this bit of code could use a comment explaining what it is
for.  It isn't clear from the context that this is used solely for
debug info generation.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]