Re: [plugins] [patch] Add new testcases and dejagnu support for plugin mechanism

[Le-Chun Wu <lcwu at google dot com>]

On Wed, Mar 25, 2009 at 3:35 AM, Rafael Espindola <espindola@google.com> wrote:
>>        * gcc/testsuite/gcc.dg/plugin/selfassign.c: New plugin source file.
>
> Once we enable building plugin for an installed compiler, we should
> probably move
> the plugins to a toplevel directory. Similar to what we do for
> libstdc++. We would
> have something like
>
> gcc/...
> ...
> plugins/plugin.exp
> plugins/plugin1
> plugins/plugin1/testsuite
> plugins/plugin2
> plugins/plugin2/testsuite
> ....
>
> Is that the direction you think we should go? It is probably better
> to commit your patch first and change the structure once
> we are able to build with a installed compiler.
>

I think there are two different kinds of testing we are talking about here:

1. Test the GCC plugin support/mechanism.
2. Test the functionality of individual plugins that come with GCC distribution.

The patch I sent out is primarily for testing the GCC plugin support
(so that future GCC changes/patches won't break the plugin mechanism).
Therefore I think the current location (gcc/testsuite/g{cc|++}/plugin)
is appropriate in this regard. What Rafael suggested is more related
to testing individual plugins, which should also be tied to where we
want the plugins (that are included in GCC distribution) to live.
Putting them under an unambiguous top-level directory sounds fine to
me. (Of course both kinds of testing can leverage the same support tcl
routines in gcc/testsuite/lib/plugin-support.exp.)

Le-chun