This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] win64 fix for libiberty md5.h

From: Ian Lance Taylor <iant at google dot com>
To: Ozkan Sezer <sezeroz at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 17 Mar 2009 15:53:27 -0700
Subject: Re: [PATCH] win64 fix for libiberty md5.h
References: <647fe9b10903140248y3fbb5193id94f370bd7dea65f@mail.gmail.com> <m3ocw05i3b.fsf@google.com> <647fe9b10903171437n67bd019awa0da612e25df58e1@mail.gmail.com>

Ozkan Sezer <sezeroz@gmail.com> writes:

>> the comment in md5.h saying that AC_CHECK_SIZEOF can not be used is out
>> of date.  With current versions of autoconf, AC_CHECK_SIZEOF works even
>> when cross-compiling.
>
> Hmm, would that need updating the top level configure.ac?
> I'm open to suggestions..  BTW, although I didn't directly hit it,
> sha1.h follows the same style as md5.h and would need similar
> changes.

It's somewhat awkward, but the procedure would be to modify md5.h,
sha1.h and splay-tree.h to include a config.h file if HAVE_CONFIG_H is
defined.  Then each user of those files would have to arrange for
uintptr_t to be defined in the appropriate config.h file.

I'd be happy to hear if a build system maintainer has a better
suggestion.

Ian

Follow-Ups:
- Re: [PATCH] win64 fix for libiberty md5.h
  - From: DJ Delorie

References:
- [PATCH] win64 fix for libiberty md5.h
  - From: O.Sezer
- Re: [PATCH] win64 fix for libiberty md5.h
  - From: Ian Lance Taylor
- Re: [PATCH] win64 fix for libiberty md5.h
  - From: Ozkan Sezer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]