This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Pack better some GCC internal data structures on 64-bit hosts

From: Tom Tromey <tromey at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 17 Mar 2009 13:34:54 -0600
Subject: Re: [PATCH] Pack better some GCC internal data structures on 64-bit hosts
References: <20090317160028.GD4561@tyan-ft48-01.lab.bos.redhat.com> <m3iqm8m4wj.fsf@fleche.redhat.com> <20090317173722.GK4561@tyan-ft48-01.lab.bos.redhat.com>
Reply-to: Tom Tromey <tromey at redhat dot com>

>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:

Jakub> struct cpp_dir
Jakub> -	/* size: 80, cachelines: 2 */
Jakub> -	/* sum members: 62, holes: 2, sum holes: 11 */
Jakub> -	/* padding: 7 */
Jakub> +	/* size: 64, cachelines: 1 */
Jakub> +	/* sum members: 62, holes: 1, sum holes: 2 */

Tom> I didn't see this in the diff.

Jakub> See
Jakub> 	* include/cpplib.h (struct cpp_dir): Reorder fields for 64-bit hosts.
Jakub> (at the very end of the patch).

Thanks for pointing that out.  I had misread the patch.
Just for the record, the libcpp changes are fine by me, thanks for
doing this.

Tom

References:
- [PATCH] Pack better some GCC internal data structures on 64-bit hosts
  - From: Jakub Jelinek
- Re: [PATCH] Pack better some GCC internal data structures on 64-bit hosts
  - From: Tom Tromey
- Re: [PATCH] Pack better some GCC internal data structures on 64-bit hosts
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]