This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix powerpc -mtune=cell -m64 and insn patterns (PR target/39226)


On Tue, Mar 03, 2009 at 09:24:57AM -0500, David Edelsohn wrote:
> If I understand correctly, you are leaving the tests to disable
> generation of the
> microcoded instructions and removing the combiner patterns that split those
> instructions.  I believe the intention of those patterns was to
> generate the "and"
> and "compare"separately through the splitter, which is what you are trying to
> accomplish by removing the patterns.  In other words, both the current machine
> description and your change are trying to accomplish the same thing, but you
> are saying the current implementation is broken.

Yeah.

> Also, if you remove the combine patterns, which always split, I think the
> associated splitters should be removed as well.

The splitters are still needed for the *_mc patterns, they were shared
between the *_nomc and *_mc patterns before.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]