This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MIPS .mdebug.abi64 / .mdebug.abiN64


Richard Sandiford <rdsandiford@googlemail.com> writes:
> Daniel Jacobowitz <drow@false.org> writes:
>> Hi Richard,
>>
>> We discovered that this patch:
>>
>> 2007-10-19  Richard Sandiford  <rsandifo@nildram.co.uk>
>>
>>         * config/mips/mips.c (mips16_copy_fpr_return_value): New function,
>>         split out from...
>>         (mips_expand_epilogue): ...here.
>>         (mips_mdebug_abi_name): New function, split out from...
>>         (mips_file_start): ...here.
>>         (mips_hard_regno_mode_ok_p): New function, split out from...
>>         (override_options): ...here.
>>         (mips_expand_builtin_1): New function, split out from...
>>         (mips_expand_buitin): ...here.  Abort if we don't recognize
>>         the function.
>>
>> replaced ".mdebug.abi64" with ".mdebug.abiN64".
>
> Argh!
>
>> Was this a deliberate change?  GDB only recognizes .mdebug.abi64
>> presently.
>
> No, it was pure carelessness, sorry ;(

Here's what I applied to 4.4 and 4.3 after testing on mipsisa64-elf
and visually inspecting the -mabi=64 output.

Thanks for the heads-up, and sorry again for the stupidity.

Richard


gcc/
	* config/mips/mips.c (mips_mdebug_abi_name): Fix the handling
	of ABI_64.

Index: gcc/config/mips/mips.c
===================================================================
--- gcc/config/mips/mips.c	2009-03-01 22:28:39.000000000 +0000
+++ gcc/config/mips/mips.c	2009-03-01 22:28:43.000000000 +0000
@@ -7782,7 +7782,7 @@ mips_mdebug_abi_name (void)
     case ABI_N32:
       return "abiN32";
     case ABI_64:
-      return "abiN64";
+      return "abi64";
     case ABI_EABI:
       return TARGET_64BIT ? "eabi64" : "eabi32";
     default:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]