This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [lto][patch] Fix how we handle clones in wpa

From: Diego Novillo <dnovillo at google dot com>
To: Rafael Espindola <espindola at google dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 20 Feb 2009 09:28:08 -0500
Subject: Re: [lto][patch] Fix how we handle clones in wpa
References: <38a0d8450902190450o395d2529s71f3a205a80cc658@mail.gmail.com> <b798aad50902191526k68e2c598mf353a7f01a0500dc@mail.gmail.com> <38a0d8450902200235s183b340fr3aee5a06d5a40dca@mail.gmail.com>

On Fri, Feb 20, 2009 at 05:35, Rafael Espindola <espindola@google.com> wrote:

> So, where a function is called from is completely irrelevant to
> whether or not it should be in the set that is passed to ltrans. The
> attached patch fixes my original one.
>
> Bootstrapped and regression tested.

Better send a full patch since the old one was reverted.

> The reduced testcase I have fails with an assert without the patch and
> (correctly) fails to link with it. Not sure how to add it to the
> testsuite.

Can you add another file with the missing symbols?  Compile the other
file without LTO and just link it.

Diego.

References:
- [lto][patch] Fix how we handle clones in wpa
  - From: Rafael Espindola
- Re: [lto][patch] Fix how we handle clones in wpa
  - From: Diego Novillo
- Re: [lto][patch] Fix how we handle clones in wpa
  - From: Rafael Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]