This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: ARM va_list
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Daniel Jacobowitz <drow at false dot org>, Paul Brook <paul at codesourcery dot com>, Mark Mitchell <mark at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, janis187 at us dot ibm dot com
- Date: Fri, 20 Feb 2009 14:06:27 +0000
- Subject: Re: PATCH: ARM va_list
- References: <20090114002202.66CB94C1C098@zelda.codesourcery.com> <Pine.LNX.4.64.0901172004530.21051@digraph.polyomino.org.uk> <4973D193.3010606@codesourcery.com> <200901190110.58554.paul@codesourcery.com> <20090119170322.GA9098@caradoc.them.org> <1232639018.6156.53.camel@pc960.cambridge.arm.com> <Pine.LNX.4.64.0902061440110.30980@digraph.polyomino.org.uk> <Pine.LNX.4.64.0902192127130.8248@digraph.polyomino.org.uk>
On Thu, 2009-02-19 at 21:28 +0000, Joseph S. Myers wrote:
> This patch version gives a warning for the mangling change under the
> same -Wpsabi option (on by default for C++) as used for the x86_64 ABI
> change - it seems appropriate to be consistent among ABI changes in
> 4.4.
>
> Tested with no regressions with cross to arm-none-linux-gnueabi. OK
> to commit?
>
> 2009-02-19 Mark Mitchell <mark@codesourcery.com>
> Joseph Myers <joseph@codesourcery.com>
>
> * config/arm/arm.c (arm_builtin_va_list): New function.
> (arm_expand_builtin_va_start): Likewise.
> (arm_gimplify_va_arg_expr): Likewise.
> (TARGET_BUILD_BUILTIN_VA_LIST): Define.
> (TARGET_BUILD_BUILTIN_VA_START): Likewise.
> (TARGET_BUILD_BUILTIN_VA_ARG_EXPR): Likewise.
> (va_list_type): New variable.
> (arm_mangle_type): Mangle va_list_type appropriately.
>
> testsuite:
> 2009-02-19 Mark Mitchell <mark@codesourcery.com>
> Joseph Myers <joseph@codesourcery.com>
>
> * gcc.target/arm/va_list.c: New test.
> * g++.dg/abi/arm_va_list.C: Likewise.
> * lib/target-supports.exp (check_effective_target_arm_eabi): New
> function.
> * g++.dg/cpp0x/temp-va-arg-bug.C, g++.dg/other/stdarg1.C,
> g++.dg/warn/miss-format-1.C, g++.dg/warn/miss-format-3.C,
> g++.dg/warn/miss-format-4.C, g++.dg/warn/miss-format-5.C,
> g++.dg/warn/miss-format-6.C, g++.old-deja/g++.other/vaarg2.C,
> g++.old-deja/g++.other/vaarg3.C, g++.old-deja/g++.other/vaarg4.C,
> g++.old-deja/g++.pt/builtin.C: Use -Wno-abi on ARM EABI targets.
OK
R.
--
Richard Earnshaw Email: Richard.Earnshaw@arm.com
ARM Ltd Phone: +44 1223 400569 (Direct + VoiceMail)
110 Fulbourn Road Switchboard: +44 1223 400400
Cherry Hinton Fax: +44 1223 400410
Cambridge CB1 9NJ Web: http://www.arm.com/
UK