This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch]:PR38166
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, mrs at apple dot com, janis187 at us dot ibm dot com
- Date: Wed, 18 Feb 2009 18:43:35 +0100
- Subject: Re: [Patch]:PR38166
- References: <20090218172821.GA31494@bromo.med.uc.edu>
On Wed, Feb 18, 2009 at 6:28 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> The attached patch skips g++.dg/ext/visibility/class1.C
> on darwin as Apple does in their trees. Tested on
> powerpc-apple-darwin9. Okay for gcc trunk?
The skip-if looks unnecessary as we have an explicit target list.
Richard.
> Jack
>
> 2009-02-18 Jack Howarth <howarth@bromo.med.uc.edu>
>
> PR testsuite/38166
> * g++.dg/ext/visibility/class1.C: Skip on Darwin.
>
> Index: gcc/testsuite/g++.dg/ext/visibility/class1.C
> ===================================================================
> --- gcc/testsuite/g++.dg/ext/visibility/class1.C (revision 144262)
> +++ gcc/testsuite/g++.dg/ext/visibility/class1.C (working copy)
> @@ -2,7 +2,8 @@
> // Init should not be hidden, so calling it should use the PLT.
>
> // { dg-options "-fpic" }
> -// { dg-do compile { target i?86-*-* x86_64-*-* *-*-darwin* } }
> +// { dg-do compile { target i?86-*-* x86_64-*-* } }
> +// { dg-skip-if "" { *-*-darwin* } { "*" } { "" } }
> // { dg-require-visibility "" }
> // { dg-final { scan-assembler "InitEv@PLT|indirect_symbol.*InitEv" } }
>
>