This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lto][patch] Always clone nodes when inlining
- From: Diego Novillo <dnovillo at google dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Simon Baldwin <simonb at google dot com>
- Date: Tue, 17 Feb 2009 08:10:27 -0500
- Subject: Re: [lto][patch] Always clone nodes when inlining
- References: <38a0d8450902170156p7a62852r26dbb32ad91a143@mail.gmail.com>
On Tue, Feb 17, 2009 at 04:56, Rafael Espindola <espindola@google.com> wrote:
> This disable a small optimization in cgraph_clone_inlined_nodes that
> avoids creating clones when there is only one use of a node. WPA
> handles clones in a different way and gets confused by this.
>
> It is probably better to fix WPA, so I added a FIXME. Since we have
> only found this problem now, it is probably not a very common case
> anyway.
This is obviously papering over something we are doing wrong in WPA,
but it's not clear what. Did you try fixing WPA directly? What
should we need to do for the proper fix?
Diego.