This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC] Enable LFS support for libcpp and gcc
On Fri, 13 Feb 2009, Paolo Bonzini wrote:
> Tom Tromey wrote:
> >>>>>> "Richard" == Richard Guenther <rguenther@suse.de> writes:
> >
> > Richard> This patch enables large-file support for libcpp and gcc.
>
> Since this is just a build patch, I approve it. However, it is not
Thanks.
> sufficient alone; you should grep for "seek" in gcc/* and change the
> relevant variables from long to off_t. A 2GB PCH is weird, but not so
> impossible.
All of them I find (but one that correctly uses off_t) use fseek()
which explicitly is using 'long' offsets.
> gcov files also explicitly want a 32-bit integer (see gcov-io.h). I
> guess this can be left as is.
I also think this is ok.
I have committed the patch.
Richard.