This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.5] Make cpplib use compiler's diagnostic.c
On Wed, 11 Feb 2009, Paolo Bonzini wrote:
> Joseph S. Myers wrote:
> > The fourth is removed by this patch as
> > unused experimental code; if someone has an actual use for it, it can
> > be added back and updated at the point where the use for it is added.
>
> The use for makedepend should have been to implement automatic
> dependency generation for gcc. This was reverted because of a GNU make
> bug. It was also meant as an example of libcpp since its API is not
> documented at all.
That may have been Zack's original intent, but Tom's patch that was
reverted used dependencies as a side effect of compilation (-M options),
not a separate makedepend program. (Not that this changes my point that
the program can be added when a use for it is added, but until then
updating it is a waste of time.)
> Since it inhibits errors and warnings, and so does not require any
> callback, fixing it might have been a smaller task than removing it...
It does require a callback. The mechanism for inhibiting errors and
warnings is removed; users that don't want them need to provide a callback
that discards them (but does something sensible with ICEs rather than
discarding those).
> are you committing this patch to your 4.5 C branch? If so, can you
> please just commit the Makefile.in hunk and leave makedepend.c in, so
> that I can follow up and fix it?
As this is not a standards conformance patch I'm not committing it to the
branch.
--
Joseph S. Myers
joseph@codesourcery.com