This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lto][patch] Use @args when calling lto-wrapper
Rafael Espindola <espindola@google.com> writes:
> 2009-02-04 Rafael Avila de Espindola <espindola@google.com>
>
> * Makefile.def: all-lto-plugin depends on all-libiberty.
> * Makefile.in: Regenerate.
>
> libiberty
> 2009-02-04 Rafael Avila de Espindola <espindola@google.com>
>
> * configure.ac: Build shared by default.
> * configure: Regenerate.
>
> lto-plugin
> 2009-02-04 Rafael Avila de Espindola <espindola@google.com>
>
> * Makefile.am (liblto_plugin_la_LIBADD): Link with libiberty.
> * Makefile.in: Regenerate.
> * lto-plugin.c (add_output_files): Argument is now a FILE.
> (exec_lto_wrapper): Use writeargv and pex.
This looks fine to me.
The only real issue is always building a PIC version of libiberty.
That is useless work in many cases, and in particular is useless for
the GNU binutils and gdb. So it might be better if we can arrange to
only do it when we need to build lto-plugin. That would also fix the
fact that this approach won't work if somebody configures gcc with
--disable-shared. This is irrelevant for lto-branch, just something
to think about before the mainline merge.
Ian