Re: [lto][patch] Use @args when calling lto-wrapper

[Andrew Thomas Pinski <pinskia at gmail dot com>]

Sent from my iPhone

On Feb 4, 2009, at 7:19 AM, Rafael Espindola <espindola@google.com>  
wrote:

> > There is already a function in libiberty which is able to write out
> > the @-file (writeargv), I think you should use that instead of doing
> > it yourself.  writeargv is able to handle arguments which have white
> > spaces and quotes.
>
> The attached patch changes the plugin to use it.
>
>
> > Also lto-plugin should use the pex interface instead of fork/execv.
>
> What is the advantage for the simple case of just one subcommand?  
> The plugin
> only works on ELF systems...

Think cross compilers. The plugin works for elf targets but not  
limited to elf hosts.  And yes this important to some developers;  
having the plugin work under windows for elf targets is very important  
to me.

> > Thanks,
> > Andrew Pinski
>
> 2009-02-04  Rafael Avila de Espindola  <espindola@google.com>
>
>    * lto-plugin.c (exec_lto_wrapper): Use writeargv.
>
> Cheers,
> --
> Rafael Avila de Espindola
>
> Google | Gordon House | Barrow Street | Dublin 4 | Ireland
> Registered in Dublin, Ireland | Registration Number: 368047
> <cleanup.patch>