This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [c++0x] std::thread fixes
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Chris Fairles <chris dot fairles at gmail dot com>
- Date: Thu, 22 Jan 2009 18:57:24 +0100
- Subject: Re: [c++0x] std::thread fixes
- References: <4348dea50901211542p24118c39tcd0f30c37d5297b2@mail.gmail.com>
Jonathan Wakely wrote:
> As discussed recently, the names in std::thread don't follow the
> libstdc++ coding style.
>
> There's a memory leak in the case where a new thread can't be started,
> because of the shared_ptr cycle created in _M_this_ptr.
>
> The std::thread move constructor and assignment operator definitions
> are missing.
>
> _Thread_data_base doesn't need a mutex, and doesn't need to derive
> from enable_shared_from_this.
>
[snip]
Thanks Jon for this work. I understand it also includes changes in ABI,
because of the mutexes, thus, even if we are talking about C++0x mode,
it would be nice to converge as soon as possible and then do not make
changes during 4.4.x. I'd like to hear Chris too, about std::thread...
Paolo.