This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [LTO][PATCH] Fix non-whopr compilation ICE that can occur with new[]
- From: Rafael Espindola <espindola at google dot com>
- To: Simon Baldwin <simonb at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 14 Jan 2009 10:05:15 +0000
- Subject: Re: [LTO][PATCH] Fix non-whopr compilation ICE that can occur with new[]
- References: <20090113171028.9937C3FE7D8@localhost>
2009/1/13 Simon Baldwin <simonb@google.com>:
> This patch fixes an internal compiler error that can occur with non-whopr
> compilations that involve new[] allocations of objects. The patch undoes the
> change of revision 136842, which introduced this error for non-whopr
> compilation.
>
> The problem that revision 136842 was intended to address is handled by the
> later revision 137044, which augments reset_type_lang_specific to remove
> all TYPE_SIZE[_UNIT] for array decls from the IR prior to LTO serialization.
Good catch. The reset_lang_specifis is the right place to fix this
kind of problem.
Not sure if I can approve the patch, but I like it :-)
Cheers,
--
Rafael Avila de Espindola
Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047