This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lto] Fixlet for ltrans-driver
- From: Diego Novillo <dnovillo at google dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 6 Jan 2009 14:58:58 -0500
- Subject: Re: [lto] Fixlet for ltrans-driver
- References: <20081231193048.GA2589@google.com> <m3zli5jx2p.fsf@google.com>
On Mon, Jan 5, 2009 at 15:51, Ian Lance Taylor <iant@google.com> wrote:
> Diego Novillo <dnovillo@google.com> writes:
>
>> We used to have no action associated with the 'all' target in the
>> Makefile generated by ltrans-driver. This was causing random
>> failures when a file named 'all.s' existed in the directory.
>
> Better to use ".PHONY: all". See use of .PHONY in gcc/Makefile.in.
Thanks, that's much cleaner. I've committed this:
* ltrans-driver: Mark 'all' target as phony.
Index: lto/ltrans-driver
===================================================================
--- lto/ltrans-driver (revision 143097)
+++ lto/ltrans-driver (working copy)
@@ -78,8 +78,8 @@ do
echo >> $makefile
done
+echo ".PHONY: all" >> $makefile
echo "all: $outputlist" >> $makefile
-echo " @true" >> $makefile
if [ $verbose -eq 1 ] ; then
set -x