This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran, 4.5] F2003: simplifiers for array transformations
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Daniel Franke <franke dot daniel at gmail dot com>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Sat, 3 Jan 2009 10:59:37 -0800
- Subject: Re: [patch, fortran, 4.5] F2003: simplifiers for array transformations
- References: <200901031754.37734.franke.daniel@gmail.com>
On Sat, Jan 03, 2009 at 05:54:37PM +0100, Daniel Franke wrote:
>
> PR fortran/29962
> * gfortran.h (gfc_wide_strcpy): New prototype.
> * scanner.c (wide_strcpy): Renamed to ...
> (gfc_wide_strcpy): ... this. Fixed all callers.
> * simplify.c (init_result_expr): New.
> (trans_result): New.
Daniel, I've only skimmed over the diff, but noticed the
names of functions that start with trans_*. Traditionally,
functions that start with trans_* are located in the files
trans-*.c and are used to convert gfortran's black and red
trees to the TREE-SSA form. Any chance that you would
consider renaming the functions to xform_* or transform_*.
Note, this isn't a show stopper request, just something
to keep a clean segregation in the code.
--
Steve