This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][revised]: Don't XFAIL 21674.cc on darwin


On Mon, Dec 15, 2008 at 12:43:04AM +0100, Andreas Schwab wrote:
> Jack Howarth <howarth@bromo.med.uc.edu> writes:
> 
> > I think for its purposed using the orginal syntax of...
> >
> > // { dg-do run { xfail *-*-![linux]* } }
> 
> I don't see how *-*-![linux]* can match any target since there will
> never be a ! in it.
> 
> Andreas.
> 
> -- 
> Andreas Schwab, SuSE Labs, schwab@suse.de
> SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."

Andreas,
    I assumed that dejagnu treats that as a negation of the pattern match
so that it would just disallow anyting containing linux immediately after
the hyphen. You are right however. I find that, looking at some older testresults,
the formulation...

// { dg-do run { xfail *-*-![linux]* } }

in libstdc++-v3/testsuite/22_locale/ctype/is/char/2.cc makes it an UNSUPPORTED
test on darwin. This also occurs with...

// { dg-xfail-run-if "" { ! { *-*-linux* } } { "*" }  { "" } } 

and with...

// { dg-do run { xfail { ! *-*-linux* } } }

as replacements. What actually should we use that would both run the test on
all targets yet xfail all but a subset of targets?
                  Jack





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]