This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, MIPS] Fix operand numbering in bbit patterns
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Adam Nemet <anemet at caviumnetworks dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 11 Dec 2008 22:29:15 +0000
- Subject: Re: [PATCH, MIPS] Fix operand numbering in bbit patterns
- References: <18753.27048.568170.511991@foo.home>
Adam Nemet <anemet@caviumnetworks.com> writes:
> I didn't realize at the time that mips_output_conditional_branch expects the
> label to be in operands[1]. This is needed in case the destination is out of
> reach for a branch instruction and instead, an inverse conditional branch is
> generated to jump over an unconditional jump to the original destination.
>
> We apparently started generating long bbit's in fold-const.c and this broke
> bootstrap.
Doh! Sorry for not catching this during the review.
> * config/mips/mips.md (*branch_bit<bbv><mode>,
> *branch_bit<bbv><mode>_inverted): Renumber operands so that the
> label becomes operands[1].
OK, thanks.
Richard