This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix gcc.dg/weak/weak-1.c on SPARC
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Eric Botcazou <ebotcazou at adacore dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 10 Dec 2008 11:24:43 +0100
- Subject: Re: [PATCH] Fix gcc.dg/weak/weak-1.c on SPARC
- References: <200811232201.06847.ebotcazou@adacore.com> <200812070905.39222.ebotcazou@adacore.com> <m3y6yoojbm.fsf@google.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Dec 09, 2008 at 06:27:57PM -0800, Ian Lance Taylor wrote:
> Eric Botcazou <ebotcazou@adacore.com> writes:
>
> > Ping. Thanks in advance.
> >
> >> 2008-11-23 ?Eric Botcazou ?<ebotcazou@adacore.com>
> >>
> >> * final.c (output_addr_const) <SYMBOL_REF>: Call assemble_external
> >> on the associated SYMBOL_REF_DECL node, if any.
> >
> > http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01218.html
>
> This is OK.
In this case I think the mark_symbol_refs_as_used calls from
sh, s390 and arm backends can go away.
The calls are always next to an assemble_integer call, and while
s390 and arm provide their own ASM_INTEGER hook, they either call
output_addr_const directly, or for non-CONST_{INT,VECTOR} they
call default_assemble_integer which calls output_addr_const as well.
Perhaps it isn't needed in output_operand either.
At least until PR38237 is fixed, calling assemble_external multiple
times is very much visible in the generated assembly.
Jakub