This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[graphite] Some small bug fixes and improvements


Hi graphities,

here are some small bugfixes, I would like to commit these fixes to
branch and trunk. 

Tobi

Fix printing with dumpfile disabled.
====================================

 * graphite.c (print_graphite_bb): Fix printing to file != dump_file.
 (print_scop): Ditto.

Patch: graphite-Fix_printing_with_dumpfile_disabled_2008-12-09.patch

Always call find_transform()
============================

 * graphite.c (graphite_transform_loops): Always call find_transform ()
 in ENABLE_CHECKING.  So we test these code pathes, even if we do not
 generate code.

Patch: graphite-Always_call_find_transform_2008-12-09.patch

More Bugfixes
=============

 * graphite.c (new_graphite_bb): Initialize GBB_STATIC_SCHEDULE.
 (find_params_in_bb): Do not free data refs.

Patch: graphite-More_Bugfixes_2008-12-09.patch

Always call find_transform()

2008-12-09  Tobias Grosser  <grosser@fim.uni-passau.de>

	* graphite.c (graphite_transform_loops): Always call find_transform ()
	in ENABLE_CHECKING.  So we test these code pathes, even if we do not
	generate code.

diff --git a/gcc/graphite.c b/gcc/graphite.c
index 6caf8e8..140ee55 100644
--- a/gcc/graphite.c
+++ b/gcc/graphite.c
@@ -5380,6 +5380,13 @@ graphite_transform_loops (void)
 
       if (graphite_apply_transformations (scop))
         gloog (scop, find_transform (scop));
+#ifdef ENABLE_CHECKING
+      else
+	{
+	  struct clast_stmt *stmt = find_transform (scop);
+	  cloog_clast_free (stmt);
+	}
+#endif
     }
 
   /* Cleanup.  */
Fix printing with dumpfile disabled.

2008-12-09  Tobias Grosser  <grosser@fim.uni-passau.de>

	* graphite.c (print_graphite_bb): Fix printing to file != dump_file.
	(print_scop): Ditto.

diff --git a/gcc/graphite.c b/gcc/graphite.c
index 24ed264..6caf8e8 100644
--- a/gcc/graphite.c
+++ b/gcc/graphite.c
@@ -465,7 +465,7 @@ print_graphite_bb (FILE *file, graphite_bb_p gb, int indent, int verbosity)
   if (GBB_DOMAIN (gb))
     {
       fprintf (file, "       (domain: \n");
-      cloog_matrix_print (dump_file, GBB_DOMAIN (gb));
+      cloog_matrix_print (file, GBB_DOMAIN (gb));
       fprintf (file, "       )\n");
     }
 
@@ -495,7 +495,7 @@ print_graphite_bb (FILE *file, graphite_bb_p gb, int indent, int verbosity)
   if (GBB_CONDITIONS (gb))
     {
       fprintf (file, "       (conditions: \n");
-      dump_gbb_conditions (dump_file, gb);
+      dump_gbb_conditions (file, gb);
       fprintf (file, "       )\n");
     }
 
@@ -549,7 +549,7 @@ print_scop (FILE *file, scop_p scop, int verbosity)
   fprintf (file, "       (data dependences: \n");
 
   if (SCOP_DEP_GRAPH (scop))
-    graphite_dump_dependence_graph (dump_file, SCOP_DEP_GRAPH (scop));
+    graphite_dump_dependence_graph (file, SCOP_DEP_GRAPH (scop));
 
   fprintf (file, "       )\n");
 
More Bugfixes

2008-12-09  Tobias Grosser  <grosser@fim.uni-passau.de>

	* graphite.c (new_graphite_bb): Initialize GBB_STATIC_SCHEDULE.
	(find_params_in_bb): Do not free data refs.

diff --git a/gcc/graphite.c b/gcc/graphite.c
index 140ee55..40c57d8 100644
--- a/gcc/graphite.c
+++ b/gcc/graphite.c
@@ -1063,6 +1063,7 @@ new_graphite_bb (scop_p scop, basic_block bb)
   GBB_CONDITIONS (gbb) = NULL;
   GBB_CONDITION_CASES (gbb) = NULL;
   GBB_LOOPS (gbb) = NULL;
+  GBB_STATIC_SCHEDULE (gbb) = NULL;
   VEC_safe_push (graphite_bb_p, heap, SCOP_BBS (scop), gbb);
 }
 
@@ -2469,7 +2470,6 @@ find_params_in_bb (scop_p scop, graphite_bb_p gb)
       irp.loop = father;
       irp.scop = scop;
       for_each_index (&dr->ref, idx_record_params, &irp);
-      free_data_ref (dr);
     }
 
   /* Find parameters in conditional statements.  */ 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]