This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR 38416, Make pragma_kind field 8 bits instead of 7.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 5 Dec 2008 20:12:49 +0000 (UTC)
- Subject: Re: [PATCH] PR 38416, Make pragma_kind field 8 bits instead of 7.
- References: <20081205191559.GA19895@hungry-tiger.westford.ibm.com>
On Fri, 5 Dec 2008, Michael Meissner wrote:
> I was reworking the parser for named address support, and I noticed that the
> pragma_kind field of the c_token was 7 bits long, when the precedding fields
> were 8 bits, and the next field was a tree. Thus we aren't saving anything by
> using 7 bits instead of 8, and 8 would allow for the use of byte instructions
> to fetch the value.
>
> If we weren't in stage 3, I would probably just commit this as obvious. I can
> commit it now or hold off until 4.5 opens up. Should I apply this to the tree?
>
> 2008-12-05 Michael Meissner <meissner@linux.vnet.ibm.com>
>
> PR c/38416
> * c-parser.c (struct c_token): Make pragma_kind 8 bits.
This is OK; it's fallout from the removal of the in_system_header bit,
which previously gave a reason for this to be 7 bits.
--
Joseph S. Myers
joseph@codesourcery.com