This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] PR 38416, Make pragma_kind field 8 bits instead of 7.


I was reworking the parser for named address support, and I noticed that the
pragma_kind field of the c_token was 7 bits long, when the precedding fields
were 8 bits, and the next field was a tree.  Thus we aren't saving anything by
using 7 bits instead of 8, and 8 would allow for the use of byte instructions
to fetch the value.

If we weren't in stage 3, I would probably just commit this as obvious.  I can
commit it now or hold off until 4.5 opens up.  Should I apply this to the tree?

2008-12-05  Michael Meissner  <meissner@linux.vnet.ibm.com>

	PR c/38416
	* c-parser.c (struct c_token): Make pragma_kind 8 bits.

--- gcc/c-parser.c.~1~	2008-12-05 11:42:01.000000000 -0500
+++ gcc/c-parser.c	2008-12-05 14:06:21.000000000 -0500
@@ -148,7 +148,7 @@ typedef struct c_token GTY (())
   ENUM_BITFIELD (rid) keyword : 8;
   /* If this token is a CPP_PRAGMA, this indicates the pragma that
      was seen.  Otherwise it is PRAGMA_NONE.  */
-  ENUM_BITFIELD (pragma_kind) pragma_kind : 7;
+  ENUM_BITFIELD (pragma_kind) pragma_kind : 8;
   /* The value associated with this token, if any.  */
   tree value;
   /* The location at which this token was found.  */

-- 
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]