This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH]: fix misc darwin9 hard-codings

From: Andreas Tobler <andreast-list at fgznet dot ch>
To: Jack Howarth <howarth at bromo dot med dot uc dot edu>
Cc: gcc-patches at gcc dot gnu dot org, mrs at apple dot com
Date: Sun, 30 Nov 2008 22:38:48 +0100
Subject: Re: [PATCH]: fix misc darwin9 hard-codings
References: <20081130153219.GA24246@bromo.med.uc.edu>

Jack Howarth wrote:

The attach patch corrects a number of remaining instances where
configure and testcases were hard coded to darwin9. These should
be expanded to darwin[912] to allow for darwin10 and later. Tested
on x86_64-apple-darwin10. Okay for gcc trunk?
              Jack

2008-11-29 Jack Howarth <howarth@bromo.med.uc.edu>

	configure: Expand to darwin10 and later.
	configure.ac: Likewise.
	gcc/testsuite/gcc.dg/darwin-comm.c: Likewise.
	libjava/configure: Likewise.
	libjava/configure.ac: Likewise.
	libjava/testsuite/lib/libjava.exp: Likewise.

This is not ok, in terms of the ChangeLog entries.

It should be:

2008-11-29 Jack Howarth <howarth@bromo.med.uc.edu>

 	configure.ac: Expand to darwin10 and later.
 	configure: Regenerate.
 	gcc/testsuite/gcc.dg/darwin-comm.c: Expand to darwin10 and later.
 	libjava/configure.ac: Expand to darwin10 and later.
 	libjava/configure: Regenrate.
 	libjava/testsuite/lib/libjava.exp: Expand to darwin10 and later.

Did you already find a victim to do this commit?

If not, I'll do, but I need another 24h plus.

Andreas

References:
- [PATCH]: fix misc darwin9 hard-codings
  - From: Jack Howarth

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]