This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [LTO][PATCH] Fix lto1 ICE in pp_base_format
- From: "Manuel López-Ibáñez" <lopezibanez at gmail dot com>
- To: "Simon Baldwin" <simonb at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 21 Nov 2008 17:25:05 +0100
- Subject: Re: [LTO][PATCH] Fix lto1 ICE in pp_base_format
- References: <20081121143319.413DD3FEA87@localhost>
2008/11/21 Simon Baldwin <simonb@google.com>:
> This patch fixes a compiler error that can occur in lto1 where a backend
> diagnostic message contains a %E formatter. Without the patch lto1 fails
> at pretty-print.c:559, for example:
>
> +/* Called during diagnostic message formatting process to print a
> + source-level entity onto BUFFER. This is a slightly extended version
> + of default_tree_printer() from toplev.c, and adds support for the '%E'
> + for error messages printed by backends. */
> +
So why not extend default_tree_printer() instead of duplicating all this code?
Cheers,
Manuel.