This is the mail archive of the
mailing list for the GCC project.
Re: [patch]: Merge from gnustep for obj-c. Remove warnings for target w64.
- From: Kai Tietz <Kai dot Tietz at onevision dot com>
- To: "Andrew Pinski" <pinskia at gmail dot com>
- Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 21 Nov 2008 13:09:58 +0100
- Subject: Re: [patch]: Merge from gnustep for obj-c. Remove warnings for target w64.
"Andrew Pinski" <email@example.com> wrote on 19.11.2008 19:23:16:
> On 11/18/08, Kai Tietz <Kai.Tietz@onevision.com> wrote:
> > Hi,
> > this patch removes some warnings in libobjc, and is a merge from the
> > changes already applied to gnustep/objc.
> > ChangeLog
> > 2008-11-18 Kai Tietz <firstname.lastname@example.org>
> > * Object.m (errno): Declare for _WIN32 as dllimported.
> Please include errno.h instead, most of the time the use of the plain
> variable errno is incorrect.
> > (compare): Cast self to id to prevent warning on comparison.
> > * objc/objc.h (BOOL): Prevent redeclaration of BOOL, if
> > there.
> > * sendmsg.c (__objc_print_dtable_stats): Remove type warnings.
> > * thr-win32.c (__objc_thread_detach): Remove type warning.
> > (__objc_thread_id): Likewise.
> > * thr.c (__objc_thread_detach_function): Add abort for
> > code.
> objc_thread_exit should have been marked as noreturn. Do you know why
> it was not?
> With the above changes and the undef change this is OK.
> Andrew Pinski
I adjusted the patch as you mentioned and replaced the abort() call by
__builtin_trap() as we discussed on IRC.
Committed revision 142087.
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.