This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, testsuite] Fix PR37033, gcc.dg/pch/valid-1b.c failures

From: "Uros Bizjak" <ubizjak at gmail dot com>
To: janis187 at us dot ibm dot com
Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>
Date: Tue, 18 Nov 2008 09:20:34 +0100
Subject: Re: [PATCH, testsuite] Fix PR37033, gcc.dg/pch/valid-1b.c failures
References: <5787cf470811170339s295c4524md47de90456238157@mail.gmail.com> <1226955425.6289.4.camel@janis-laptop>

On Mon, Nov 17, 2008 at 9:57 PM, Janis Johnson <janis187@us.ibm.com> wrote:

>> We can add -fno-dwarf2-cfi-asm to gcc.dg/pch/valid-1b.hs to suppress
>> definition of __GCC_HAVE_DWARF2_CFI_ASM in -g case.
>>
>> 2008-11-17  Uros Bizjak  <ubizjak@gmail.com>
>>
>>       PR testsuite/37033
>>       * gcc.dg/pch/valid-1b.hs (dg-options): Add -fno-dwarf2-cfi-asm.
>>
>> Patch was tested on i686-pc-linux-gnu, fixes all pch failures. OK for mainline?
>
> I know nothing about PCH and don't want to approve this patch, but
> the PR has been stagnant for months.  If anyone at all who knows
> something about PCH says says this looks reasonable, then OK.

The problem is, that -g now generates __GCC_HAVE_DWARF2_CFI_ASM with
-g flag (and not with -g0) on dwarf2 targets. So this testcase is
either invalid or we should add -fno-dwarf-cfi-asm to -g flag to
suppress generation of __G_H_D_C_A.

Uros.

Follow-Ups:
- Re: [PATCH, testsuite] Fix PR37033, gcc.dg/pch/valid-1b.c failures
  - From: Joseph S. Myers

References:
- [PATCH, testsuite] Fix PR37033, gcc.dg/pch/valid-1b.c failures
  - From: Uros Bizjak
- Re: [PATCH, testsuite] Fix PR37033, gcc.dg/pch/valid-1b.c failures
  - From: Janis Johnson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]