This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, testsuite] Fix PR37033, gcc.dg/pch/valid-1b.c failures
On Mon, Nov 17, 2008 at 9:57 PM, Janis Johnson <email@example.com> wrote:
>> We can add -fno-dwarf2-cfi-asm to gcc.dg/pch/valid-1b.hs to suppress
>> definition of __GCC_HAVE_DWARF2_CFI_ASM in -g case.
>> 2008-11-17 Uros Bizjak <firstname.lastname@example.org>
>> PR testsuite/37033
>> * gcc.dg/pch/valid-1b.hs (dg-options): Add -fno-dwarf2-cfi-asm.
>> Patch was tested on i686-pc-linux-gnu, fixes all pch failures. OK for mainline?
> I know nothing about PCH and don't want to approve this patch, but
> the PR has been stagnant for months. If anyone at all who knows
> something about PCH says says this looks reasonable, then OK.
The problem is, that -g now generates __GCC_HAVE_DWARF2_CFI_ASM with
-g flag (and not with -g0) on dwarf2 targets. So this testcase is
either invalid or we should add -fno-dwarf-cfi-asm to -g flag to
suppress generation of __G_H_D_C_A.