This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] fix bootstrap on powerpc targets which do not include svr4.h


David Edelsohn wrote:
I don't think this patch is correct.  It will work, but it is the most
conservative
patch to define the macro and allow GCC to compile.  The real problem is
the configure lines for powerpc-freebsd and powerpc-netbsd have not been
maintained.  FreeBSD apparently uses GAS, but usegas.h is not included.
It uses SVR4, but svr4.h is not included.

Regarding usegas.h, I think if GAS is the default assembler on FreeBSD then there is no issue not including it.
The thing I can't find an answer myself is the reason for not including svr4.h. I read the threads from November 01 when this port came in. There it was never mentioned to include svr4.h or not.
Hopefully there is a simple explanantion.


Either these should be included, or the FreeBSD and NetBSD configurations
should define SVR4_ASM_SPEC.  Currently they use and assume SVR4
on PowerPC, but are not self-consistent.

If there is a good reason not to include svr4.h I'm happy to prepare a patch which defines the SVR4_ASM_SPEC in rs6000/freebsd.h/netbsd.h.


I'm looking forwar to understand a bit more of these ports.

Thank you for review.
Andreas





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]