This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, testsuite]: Synchronize dg-options in {gcc,g++}.dg/compat/struct-layout-1_generate.c
- From: Jack Howarth <howarth at bromo dot msbb dot uc dot edu>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 15 Nov 2008 01:34:02 -0500
- Subject: Re: [PATCH, testsuite]: Synchronize dg-options in {gcc,g++}.dg/compat/struct-layout-1_generate.c
- References: <491C733C.1010104@gmail.com>
On Thu, Nov 13, 2008 at 07:34:36PM +0100, Uros Bizjak wrote:
> Hello!
>
> This patch synchronizes dg-options array in
> {gcc,g++}.dg/compat/struct-layout-1_generate.c.
>
> The patch fixes at least
>
> Running target unix
> FAIL: tmpdir-gcc.dg-struct-layout-1/t027
> c_compat_x_tst.o-c_compat_y_tst.o execute
>
> 2008-11-13 Uros Bizjak <ubizjak@gmail.com>
>
> * gcc.dg/compat/struct-layout-1_generate.c (dg-options): Add -mno-mmx
> for i?86-*-* and x86_64-*-* targets
> * g++.dg/compat/struct-layout-1_generate.c (dg-options): Add
> -fno-common for *-*-darwin* *-*-mingw32* *-*-cygwin* targets.
>
>
> Patch was tested on x86_64-pc-linux-gnu {,-m32}, committed to mainline
> as obvious.
>
> Uros.
> Index: g++.dg/compat/struct-layout-1_generate.c
> ===================================================================
> --- g++.dg/compat/struct-layout-1_generate.c (revision 141824)
> +++ g++.dg/compat/struct-layout-1_generate.c (working copy)
> @@ -45,7 +45,7 @@ along with GCC; see the file COPYING3.
> const char *dg_options[] = {
> "/* { dg-options \"%s-I%s\" } */\n",
> "/* { dg-options \"%s-I%s -mno-mmx\" { target i?86-*-* x86_64-*-* } } */\n",
> -"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* } } */\n",
> +"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-darwin* *-*-mingw32* *-*-cygwin* } } */\n",
> "/* { dg-options \"%s-I%s -mno-base-addresses\" { target mmix-*-* } } */\n",
> "/* { dg-options \"%s-I%s -mlongcalls -mtext-section-literals\" { target xtensa*-*-* } } */\n"
> #define NDG_OPTIONS (sizeof (dg_options) / sizeof (dg_options[0]))
> Index: gcc.dg/compat/struct-layout-1_generate.c
> ===================================================================
> --- gcc.dg/compat/struct-layout-1_generate.c (revision 141824)
> +++ gcc.dg/compat/struct-layout-1_generate.c (working copy)
> @@ -44,6 +44,7 @@ along with GCC; see the file COPYING3.
>
> const char *dg_options[] = {
> "/* { dg-options \"%s-I%s\" } */\n",
> +"/* { dg-options \"%s-I%s -mno-mmx\" { target i?86-*-* x86_64-*-* } } */\n",
> "/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-darwin* *-*-mingw32* *-*-cygwin* } } */\n",
> "/* { dg-options \"%s-I%s -mno-base-addresses\" { target mmix-*-* } } */\n",
> "/* { dg-options \"%s-I%s -mlongcalls -mtext-section-literals\" { target xtensa*-*-* } } */\n"
Uros,
Reverting the darwin change to g++.dg/compat/struct-layout-1_generate.c with...
Index: gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c
===================================================================
--- gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c (revision 141878)
+++ gcc/testsuite/g++.dg/compat/struct-layout-1_generate.c (working copy)
@@ -45,7 +45,7 @@
const char *dg_options[] = {
"/* { dg-options \"%s-I%s\" } */\n",
"/* { dg-options \"%s-I%s -mno-mmx\" { target i?86-*-* x86_64-*-* } } */\n",
-"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-darwin* *-*-mingw32* *-*-cygwin* } } */\n",
+"/* { dg-options \"%s-I%s -fno-common\" { target hppa*-*-hpux* *-*-mingw32* *-*-cygwin* } } */\n",
"/* { dg-options \"%s-I%s -mno-base-addresses\" { target mmix-*-* } } */\n",
"/* { dg-options \"%s-I%s -mlongcalls -mtext-section-literals\" { target xtensa*-*-* } } */\n"
#define NDG_OPTIONS (sizeof (dg_options) / sizeof (dg_options[0]))
eliminates the new regression in the g++.dg/compat/struct-layout-1.exp testsuite such that...
FAIL: tmpdir-g++.dg-struct-layout-1/t026 cp_compat_x_tst.o-cp_compat_y_tst.o execute
no longer occurs. Can you apply that change to gcc trunk?
Jack