This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[testsuite] Avoid clash between lines and columns


Now that we can track column numbers in testcases, it may occur that a
test that was meant to match a line, matches instead a column number,
hiding (or causing) a bogus failure. This can be triggered easily with
dg-bogus as done in the testcase added. This is not a problem right
now but it shows up as soon as one starts adding -fshow-column to
testcases.

The only drawback of this approach is that the output of dejagnu is
now quite ugly:

New tests that FAIL:

unix//-m64: g++.old-deja/g++.mike/warn1.C  (test for errors, line
[^:][^0-9]:12:)


Not sure how to fix this. Any ideas? Janis?

Bootstrapped and regression tested with
--enable-languages=all,obj-c++,ada on x86_64-unknown-linux-gnu

OK for trunk? 4.5?

Cheers,

Manuel.

2008-11-14  Manuel López-Ibáñez  <manu@gcc.gnu.org>

gcc/testsuite/	
	* lib/gcc-dg.exp: Wrapper around dg-bogus.
	(process-message): Make sure what is matched is a line and not a
	column.
	* gcc.dg/bogus-column.c: New.

Attachment: dg-bogus-column.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]