This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libcpp+C++ PATCH] Fix -Wempty-body C++ warning (PR c++/36478)

Jakub Jelinek wrote:
> On Tue, Nov 11, 2008 at 06:01:57PM -0800, Mark Mitchell wrote:
>> Maybe this just argues for reverting Mike's patch.
> 
> Fine with my, should I prepare a patch?

Yes, I think that's probably the thing to do.

I think that Mike's patch is too closely tied to the coding conventions
of particular users.  If we're going to warn about this at all (and I
think we should), we should do so independent of the exact use of
whitespace and such.

I believe that Lint had special comments to disable certain warnings.
If we want, we could have comments/pragmas/etc. that users could use to
explicitly disable this warning.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]