This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix small structure passing on x86-64

From: Michael Matz <matz at suse dot de>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Richard Guenther <richard dot guenther at gmail dot com>, Uros Bizjak <ubizjak at gmail dot com>, Eric Botcazou <ebotcazou at adacore dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 11 Nov 2008 18:29:19 +0100 (CET)
Subject: Re: [PATCH] Fix small structure passing on x86-64
References: <490B5E88.3080101@gmail.com> <84fc9c000811110834r7b91f42fna37680ebde0d2bdf@mail.gmail.com> <6dc9ffc80811110844g6b5e42f7ifb91c55442831e8d@mail.gmail.com>

Hi,

On Tue, 11 Nov 2008, H.J. Lu wrote:

> >> This is OK for mainline and all release branches after a couple of 
> >> days in mainline without problems.
> >
> > Please do not put this onto the active branches.  We're not yet sure 
> > the patch is correct.
> >
> 
> FWIW, that is what icc does. Gcc was wrong.

There's no argument that GCC was wrong, and what should happen instead.  
The problem is to be sure that the patch does what it intended.  Small 
structs could now be copied with a movq which might be a problem if they 
are unaligned (not just containing unaligned fields).

Ciao,
Michael.

References:
- Re: [PATCH] Fix small structure passing on x86-64
  - From: Richard Guenther
- Re: [PATCH] Fix small structure passing on x86-64
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]