This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [CPP] fix some diagnostic locations

Hi Tom,

attached is the part of my patch that fixes libcpp locations. As you
can see it is practically a subset of yours. However, we are causing
the same failure in cpp/literals-2.c. The reason is that by the time
we lex the 'x and reach lex_string we have already jumped to the next
line. I don't know where we jump to the next line or whether we could
backtrace this jump somehow.

Could you give it a try? It affects both of us and if you could fix
this, or at least find more information about the problem, it will
help me a lot.



2008/11/3 Manuel LÃpez-IbÃÃez <>:
> 2008/10/31 Tom Tromey <>:ä>>>>>> "Manuel" == Manuel
> LÃpez-IbÃÃez <> writes:
>> Tom> If you plan to do more work in this area, and you'd like it as a
>> Tom> starting point, I can send it.
>> Manuel> Yes definitely.
>> I've appended it.  I haven't updated my trunk tree recently so I would
>> not be surprised if it did not apply cleanly.
> I have updated it to a recent revision and fixed a few failures.
> However, I wasn't able to fix the remaining. Your code to fix dg-bogus
> when using columns did not work. I implemented a different approach.
> It seems to work fine except for the ugly output. The updated patch is
> attached. The failures I wasn't able to fix were:
> New tests that FAIL:
> unix//-m64: gcc.dg/cpp/trad/funlike.c macro-expanded parenthesis (test
> for errors, line [^:][^0-9]:24:)
> unix//-m64: gcc.dg/cpp/trad/funlike.c (test for excess errors)
> unix//-m64: gcc.dg/cpp/trad/literals-2.c bad charconst (test for
> errors, line [^:][^0-9]:7:)
> unix//-m64: gcc.dg/cpp/trad/literals-2.c bad charconst (test for
> warnings, line [^:][^0-9]:7:)
> unix//-m64: gcc.dg/cpp/trad/literals-2.c (test for excess errors)
> unix//-m64: gcc.dg/pr28322-3.c  (test for warnings, line [^:][^0-9])

Attachment: fix-cpp-location-4.diff
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]