This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR 36322/36463


Janus,

Have patience - the few reviewers that there are have daytime jobs too.

This looks OK for trunk, subject a remark being resolved according
unto conscience:

It is conventional to tip a hat to the reporters in the "Contributed
by" line in the test cases, unless the final result is very far
removed from the original.  Whilst I am sure that Tobias and Dominique
just want the bugs fixed, it helps in general if we acknowledge the
reporter.  Your claim to fame is in the Changelog:-)


Cheers

Paul



On Fri, Oct 31, 2008 at 8:40 PM, Janus Weil <jaydub66@googlemail.com> wrote:
>>> here is a slighty modified version of the patch (triggered by a
>>> comment of Tobias), including an additional test case.
>>
>> Sorry, the test case in the patch was messed up. Here goes the
>> corrected version ...
>
> ping!
>
> I'm still waiting for this patch to be approved ...
>
> Updated Changelog:
>
> 2008-10-31  Janus Weil  <janus@gcc.gnu.org>
>
>        PR fortran/36322
>        PR fortran/36463
>        * gfortran.h: New function gfc_expr_replace_symbols.
>        * decl.c (match_procedure_decl): Increase reference count for interface.
>        * expr.c: New functions replace_symbol and gfc_expr_replace_symbols.
>        * resolve.c (resolve_symbol): Correctly copy array spec and char len
>        of PROCEDURE declarations from their interface.
>        * symbol.c (gfc_get_default_type): Enhanced error message.
>        (copy_formal_args): Call copy_formal_args recursively for arguments.
>        * trans-expr.c (gfc_conv_function_call): Bugfix.
>
> 2008-10-31  Janus Weil  <janus@gcc.gnu.org>
>
>        PR fortran/36322
>        PR fortran/36463
>        * gfortran.dg/proc_decl_17.f90: New.
>        * gfortran.dg/proc_decl_18.f90: New.
>



-- 
The knack of flying is learning how to throw yourself at the ground and miss.
       --Hitchhikers Guide to the Galaxy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]